[imapfilter-devel] imapfilter locks

[Lefteris Chatzibarbas]

On Mon, Jan 16, 2006 at 11:41:39AM +0100, Vaclav Vinklat wrote:
> Hello, everybody,
> during usage of this smart filter I found problem with one incoming message.
> While it is still in Inbox marked as unread, imapfilter discontinue in 
> progress (see verbose output)
> Only deletion message or mark as read solve a problem.
> (sample maildir and lua config are in attachments)

Hello,

We tracked down the problem with Vaclav some days ago and I was planning
on making a release that would include a fix, but other people seem to
have this problem, too, so as a temporary solution for now...

This message contains some ASCII NUL 0x00 characters, something that is
probably not valid for mail messages (AFAIK, binary data must be encoded in a
textual form, such as BASE64).

We can probably get away with such messages with the patch I'm attaching.  So
anyone having similar problems can apply this patch against imapfilter 1.1.1:

  tar zxf imapfilter-1.1.1.tar.gz
  patch -p0 < patch-1.1.1-1
  ...
                                                                                
Again, I'm working on resolving this problem properly (ie. handle binary
data and NUL chars, anyway) in the next release...

L.
-------------- next part --------------
diff -ruN imapfilter-1.1.1.orig/socket.c imapfilter-1.1.1/socket.c
--- imapfilter-1.1.1.orig/socket.c	2005-11-11 01:21:37.000000000 +0200
+++ imapfilter-1.1.1/socket.c	2006-01-21 21:44:16.000000000 +0200
@@ -254,6 +254,14 @@
 		goto fail;
 	}
 
+	{
+		int i;
+		
+		for (i = 0; i < r; i++)
+			if (buf[i] == '\0')
+				buf[i] = 0x80;
+	}
+
 	return r;
 fail:
 	close_connection(ssn);