[imapfilter-devel] Small patch for Mailbox._send_query()

[Lefteris Chatzimparmpas]

On Fri, 2007-10-05 at 23:06 +0200, Hans-Werner Hilse wrote:
> Hi,
> 
> the attached patch is needed for >=imapfilter-2.0.3 in order to work
> properly -- at least with the MS Exchange and the Cyrus IMAP server.
> 
> The problem is triggered by the change in mailbox.lua: Calling
> Mailbox._send_query with no parameters (or nil, for that matter) will
> issue an IMAP call "UID SEARCH ALL ", i.e. it will have a trailing
> space. The MS Exchange server and the Cyrus IMAP server will issue an
> error message. I'm not sure about what the IMAP standard really says
> about that, but I think in order to have maximum compatibility, the
> patch should go upstream. In my case, it was triggered by calling
> Mailbox.select_all(). I'm not sure if at the moment select_all() works
> for any IMAP server at all.

Hello,

Yeap, this is a bug, that extra space shouldn't be there.

This should only be a problem for select_all(), and unfortunately it
seems that select_all() works for the server I'm doing most of the
testing...

Your patch should correct the problem, so I will release a new version
tomorrow...

> The issue is more complicated, though. I'd rather prefer if imapfilter
> would error out when the IMAP server returns error messages. Maybe,
> with some spare time, I'll get to give it a try...

This is a good idea...

Thanks

L.